Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: improve tests for cache provider #1369

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Chore: improve tests for cache provider #1369

merged 1 commit into from
Aug 24, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Aug 24, 2021

A new test case with some improvements made to existing ones.

@shuding shuding requested a review from huozhi as a code owner August 24, 2021 09:15
huozhi
huozhi approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@huozhi huozhi merged commit 22abcf1 into master Aug 24, 2021
@huozhi huozhi deleted the cache-test branch August 24, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuding @huozhi